Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: src/ic.h

Issue 451643002: Clean up IC tracing for CallICs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Code comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/globals.h ('k') | src/ic.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic.h
diff --git a/src/ic.h b/src/ic.h
index 72cc3f62c6b9248800a51cf5d3f0de17d4a45af9..98771685d33f2c4111f2382a3f40dad5a1c5b120 100644
--- a/src/ic.h
+++ b/src/ic.h
@@ -163,6 +163,8 @@ class IC {
char TransitionMarkFromState(IC::State state);
void TraceIC(const char* type, Handle<Object> name);
+ void TraceIC(const char* type, Handle<Object> name, State old_state,
+ State new_state);
MaybeHandle<Object> TypeError(const char* type,
Handle<Object> object,
@@ -335,8 +337,6 @@ class CallIC: public IC {
: argc_(argc), call_type_(call_type) {
}
- InlineCacheState GetICState() const { return ::v8::internal::GENERIC; }
-
ExtraICState GetExtraICState() const;
static void GenerateAheadOfTime(
@@ -359,7 +359,8 @@ class CallIC: public IC {
: IC(EXTRA_CALL_FRAME, isolate) {
}
- void PatchMegamorphic(Handle<FixedArray> vector, Handle<Smi> slot);
+ void PatchMegamorphic(Handle<Object> function, Handle<FixedArray> vector,
+ Handle<Smi> slot);
void HandleMiss(Handle<Object> receiver,
Handle<Object> function,
@@ -382,8 +383,8 @@ class CallIC: public IC {
ConstantPoolArray* constant_pool);
private:
- void UpdateTypeFeedbackInfo(Object* old_feedback, Object* new_feedback);
- inline IC::State FeedbackObjectToState(Object* feedback) const;
+ inline IC::State FeedbackToState(Handle<FixedArray> vector,
+ Handle<Smi> slot) const;
};
« no previous file with comments | « src/globals.h ('k') | src/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698