Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 451593002: Remove dangerous default parameter from machine Store operator. (Closed)

Created:
6 years, 4 months ago by Michael Starzinger
Modified:
6 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove dangerous default parameter from machine Store operator. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22970

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/compiler/machine-node-factory.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 4 months ago (2014-08-07 10:36:08 UTC) #1
Benedikt Meurer
lgtm
6 years, 4 months ago (2014-08-07 10:36:57 UTC) #2
Michael Starzinger
6 years, 4 months ago (2014-08-07 11:01:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 22970 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698