Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/compiler/machine-node-factory.h

Issue 451593002: Remove dangerous default parameter from machine Store operator. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/compiler/machine-operator.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_COMPILER_MACHINE_NODE_FACTORY_H_ 5 #ifndef V8_COMPILER_MACHINE_NODE_FACTORY_H_
6 #define V8_COMPILER_MACHINE_NODE_FACTORY_H_ 6 #define V8_COMPILER_MACHINE_NODE_FACTORY_H_
7 7
8 #ifdef USE_SIMULATOR 8 #ifdef USE_SIMULATOR
9 #define MACHINE_ASSEMBLER_SUPPORTS_CALL_C 0 9 #define MACHINE_ASSEMBLER_SUPPORTS_CALL_C 0
10 #else 10 #else
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 Node* Load(MachineRepresentation rep, Node* base) { 93 Node* Load(MachineRepresentation rep, Node* base) {
94 return Load(rep, base, Int32Constant(0)); 94 return Load(rep, base, Int32Constant(0));
95 } 95 }
96 Node* Load(MachineRepresentation rep, Node* base, Node* index) { 96 Node* Load(MachineRepresentation rep, Node* base, Node* index) {
97 return NEW_NODE_2(MACHINE()->Load(rep), base, index); 97 return NEW_NODE_2(MACHINE()->Load(rep), base, index);
98 } 98 }
99 void Store(MachineRepresentation rep, Node* base, Node* value) { 99 void Store(MachineRepresentation rep, Node* base, Node* value) {
100 Store(rep, base, Int32Constant(0), value); 100 Store(rep, base, Int32Constant(0), value);
101 } 101 }
102 void Store(MachineRepresentation rep, Node* base, Node* index, Node* value) { 102 void Store(MachineRepresentation rep, Node* base, Node* index, Node* value) {
103 NEW_NODE_3(MACHINE()->Store(rep), base, index, value); 103 NEW_NODE_3(MACHINE()->Store(rep, kNoWriteBarrier), base, index, value);
104 } 104 }
105 // Arithmetic Operations. 105 // Arithmetic Operations.
106 Node* WordAnd(Node* a, Node* b) { 106 Node* WordAnd(Node* a, Node* b) {
107 return NEW_NODE_2(MACHINE()->WordAnd(), a, b); 107 return NEW_NODE_2(MACHINE()->WordAnd(), a, b);
108 } 108 }
109 Node* WordOr(Node* a, Node* b) { 109 Node* WordOr(Node* a, Node* b) {
110 return NEW_NODE_2(MACHINE()->WordOr(), a, b); 110 return NEW_NODE_2(MACHINE()->WordOr(), a, b);
111 } 111 }
112 Node* WordXor(Node* a, Node* b) { 112 Node* WordXor(Node* a, Node* b) {
113 return NEW_NODE_2(MACHINE()->WordXor(), a, b); 113 return NEW_NODE_2(MACHINE()->WordXor(), a, b);
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 #undef NEW_NODE_3 375 #undef NEW_NODE_3
376 #undef MACHINE 376 #undef MACHINE
377 #undef COMMON 377 #undef COMMON
378 #undef ZONE 378 #undef ZONE
379 379
380 } // namespace compiler 380 } // namespace compiler
381 } // namespace internal 381 } // namespace internal
382 } // namespace v8 382 } // namespace v8
383 383
384 #endif // V8_COMPILER_MACHINE_NODE_FACTORY_H_ 384 #endif // V8_COMPILER_MACHINE_NODE_FACTORY_H_
OLDNEW
« no previous file with comments | « no previous file | src/compiler/machine-operator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698