Issue 451493002: Use as dynamic to get rid of warnigns in code_transformers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 451493002: Use as dynamic to get rid of warnigns in code_transformers (Closed)

Created:
6 years, 4 months ago by Siggi Cherem (dart-lang)

Modified:
6 years, 4 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use as dynamic to get rid of warnigns in code_transformers R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38951

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -13 lines)			Patch
	M	pkg/code_transformers/lib/src/dart_sdk.dart	View		1 chunk	+8 lines, -2 lines	0 comments	Download
	M	pkg/pkg.status	View		1 chunk	+0 lines, -11 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM Thanks! https://codereview.chromium.org/451493002/diff/20001/pkg/pkg.status File pkg/pkg.status (left): https://codereview.chromium.org/451493002/diff/20001/pkg/pkg.status#oldcode422 pkg/pkg.status:422: polymer/test/build/all_phases_test: StaticWarning I've added also polymer/test/build/import_inliner_test

6 years, 4 months ago (2014-08-06 20:44:24 UTC) #2

Siggi Cherem (dart-lang)

6 years, 4 months ago (2014-08-06 20:47:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 38951 (presubmit successful).

Expand Messages | Collapse Messages