Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 451483003: Clean up meaningless branch on commented-out code. (Closed)

Created:
6 years, 4 months ago by palmer
Modified:
6 years, 4 months ago
Reviewers:
Bo Xu, Nico, jun_fang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Clean up meaningless branch on commented-out code. BUG=https://code.google.com/p/pdfium/issues/detail?id=35 R=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/9047b8b

Patch Set 1 #

Patch Set 2 : Normalize whitespace. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M fpdfsdk/src/fsdk_actionhandler.cpp View 1 1 chunk +8 lines, -13 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
palmer
Here's a little cleanup.
6 years, 4 months ago (2014-08-06 20:34:54 UTC) #1
Bo Xu
On 2014/08/06 20:34:54, Chromium Palmer wrote: > Here's a little cleanup. lgtm
6 years, 4 months ago (2014-08-06 20:51:40 UTC) #2
Nico
https://codereview.chromium.org/451483003/diff/20001/fpdfsdk/src/fsdk_actionhandler.cpp File fpdfsdk/src/fsdk_actionhandler.cpp (right): https://codereview.chromium.org/451483003/diff/20001/fpdfsdk/src/fsdk_actionhandler.cpp#newcode273 fpdfsdk/src/fsdk_actionhandler.cpp:273: ASSERT(pDocument != NULL); The rest of the file uses ...
6 years, 4 months ago (2014-08-06 21:17:17 UTC) #3
palmer
Committed patchset #2 manually as 9047b8b (presubmit successful).
6 years, 4 months ago (2014-08-06 21:18:10 UTC) #4
palmer
6 years, 4 months ago (2014-08-06 21:22:35 UTC) #5
Message was sent while issue was closed.
> (Imho, we really should convert all tab-files to spaces once and then
presubmit
> for the absence of tabs.)

I see it as hopeless until we clang-format everything. So for now I'm just
trying to be consistent in functions.

Powered by Google App Engine
This is Rietveld 408576698