Clean up meaningless branch on commented-out code.

fpdfsdk/src/fsdk_actionhandler.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../include/fsdk_define.h"
 #include "../include/fsdk_mgr.h"
 #include "../include/fsdk_actionhandler.h"
 #include "../include/javascript/IJavaScript.h"
@@ skipping 251 matching lines @@
         {
                 CPDF_Action subaction = action.GetSubAction(i);
                 if (!ExecuteDocumentPageAction(subaction, type, pDocument,/* pDocView,*/ list)) return FALSE;
         }
 
         return TRUE;
 }
 
 FX_BOOL CPDFSDK_ActionHandler::IsValidField(CPDFSDK_Document* pDocument, CPDF_Dictionary* pFieldDict)
 {
-        ASSERT(m_pEvi != NULL);
-        ASSERT(pDocument != NULL);
-        ASSERT(pFieldDict != NULL);
+  ASSERT(m_pEvi != NULL);
+  ASSERT(pDocument != NULL);

[Nico, 2014/08/06 21:17:17]

The rest of the file uses tabs, we shouldn't mix tabs and spaces in one file.

(Imho, we really should convert all tab-files to spaces once and then presubmit
for the absence of tabs.)

+  ASSERT(pFieldDict != NULL);
 
-        if (1/*m_pApp->IsValidDocument(pDocument)*/)
-        {
-                CPDFSDK_InterForm* pInterForm = pDocument->GetInterForm();
-                ASSERT(pInterForm != NULL);
+  CPDFSDK_InterForm* pInterForm = pDocument->GetInterForm();
+  ASSERT(pInterForm != NULL);
 
-                CPDF_InterForm* pPDFInterForm = pInterForm->GetInterForm();
-                ASSERT(pPDFInterForm != NULL);
+  CPDF_InterForm* pPDFInterForm = pInterForm->GetInterForm();
+  ASSERT(pPDFInterForm != NULL);
 
-                return pPDFInterForm->GetFieldByDict(pFieldDict) != NULL;
-        }
-
-        return FALSE;
+  return pPDFInterForm->GetFieldByDict(pFieldDict) != NULL;
 }
 
 FX_BOOL CPDFSDK_ActionHandler::ExecuteFieldAction(const CPDF_Action& action, CPDF_AAction::AActionType type, 
                                                                                   CPDFSDK_Document* pDocument,/* CReader_DocView* pDocView,*/ CPDF_FormField* pFormField, 
                                                                                   PDFSDK_FieldAction& data, CFX_PtrList& list)
 {
         ASSERT(pDocument != NULL);
 
         if (list.Find((CPDF_Dictionary*)action))
                 return FALSE;
@@ skipping 543 matching lines @@
 FX_BOOL CPDFSDK_MediaActionHandler::DoAction_Sound(const CPDF_Action& action, CPDFSDK_Document* pDocument)
 {
         return FALSE;
 }
 
 FX_BOOL CPDFSDK_MediaActionHandler::DoAction_Movie(const CPDF_Action& action, CPDFSDK_Document* pDocument)
 {
         return FALSE;
 }