Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 451193003: Remove deprecated kBrowserActionContainerWidth pref (Closed)

Created:
6 years, 4 months ago by Devlin
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated kBrowserActionContainerWidth pref We migrated to the new kToolbarSize pref over four years ago. I think this is safe to remove. :) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289184

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove unneeded includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -45 lines) Patch
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 1 3 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 1 3 chunks +0 lines, -12 lines 0 comments Download
M extensions/browser/extension_prefs.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M extensions/browser/pref_names.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/pref_names.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Devlin
Peter (c/b/ui) and Marijn (extensions/), mind taking a look?
6 years, 4 months ago (2014-08-12 18:54:10 UTC) #1
Marijn Kruisselbrink
lgtm
6 years, 4 months ago (2014-08-12 19:01:31 UTC) #2
Peter Kasting
LGTM https://codereview.chromium.org/451193003/diff/1/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm File chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm (left): https://codereview.chromium.org/451193003/diff/1/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm#oldcode394 chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm:394: } Make sure you remove any #includes (some ...
6 years, 4 months ago (2014-08-12 19:04:49 UTC) #3
Devlin
https://codereview.chromium.org/451193003/diff/1/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm File chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm (left): https://codereview.chromium.org/451193003/diff/1/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm#oldcode394 chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm:394: } On 2014/08/12 19:04:49, Peter Kasting wrote: > Make ...
6 years, 4 months ago (2014-08-12 19:18:19 UTC) #4
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-12 20:30:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/451193003/20001
6 years, 4 months ago (2014-08-12 20:33:09 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 03:29:56 UTC) #7
Message was sent while issue was closed. 
Change committed as 289184

Powered by Google App Engine
This is Rietveld 408576698