Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

Issue 451193003: Remove deprecated kBrowserActionContainerWidth pref (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unneeded includes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/toolbar/browser_actions_container.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h" 5 #import "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 #include <string> 8 #include <string>
9 9
10 #include "base/prefs/pref_service.h"
11 #include "base/strings/sys_string_conversions.h" 10 #include "base/strings/sys_string_conversions.h"
12 #include "chrome/browser/chrome_notification_types.h" 11 #include "chrome/browser/chrome_notification_types.h"
13 #include "chrome/browser/extensions/extension_action.h" 12 #include "chrome/browser/extensions/extension_action.h"
14 #include "chrome/browser/extensions/extension_action_manager.h" 13 #include "chrome/browser/extensions/extension_action_manager.h"
15 #include "chrome/browser/extensions/extension_toolbar_model.h" 14 #include "chrome/browser/extensions/extension_toolbar_model.h"
16 #include "chrome/browser/extensions/extension_util.h" 15 #include "chrome/browser/extensions/extension_util.h"
17 #include "chrome/browser/profiles/profile.h" 16 #include "chrome/browser/profiles/profile.h"
18 #include "chrome/browser/sessions/session_tab_helper.h" 17 #include "chrome/browser/sessions/session_tab_helper.h"
19 #include "chrome/browser/ui/browser.h" 18 #include "chrome/browser/ui/browser.h"
20 #include "chrome/browser/ui/browser_window.h" 19 #include "chrome/browser/ui/browser_window.h"
21 #import "chrome/browser/ui/cocoa/extensions/browser_action_button.h" 20 #import "chrome/browser/ui/cocoa/extensions/browser_action_button.h"
22 #import "chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h" 21 #import "chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h"
23 #import "chrome/browser/ui/cocoa/extensions/extension_popup_controller.h" 22 #import "chrome/browser/ui/cocoa/extensions/extension_popup_controller.h"
24 #import "chrome/browser/ui/cocoa/image_button_cell.h" 23 #import "chrome/browser/ui/cocoa/image_button_cell.h"
25 #import "chrome/browser/ui/cocoa/menu_button.h" 24 #import "chrome/browser/ui/cocoa/menu_button.h"
26 #include "chrome/browser/ui/tabs/tab_strip_model.h" 25 #include "chrome/browser/ui/tabs/tab_strip_model.h"
27 #include "chrome/common/extensions/api/extension_action/action_info.h" 26 #include "chrome/common/extensions/api/extension_action/action_info.h"
28 #include "chrome/common/pref_names.h"
29 #include "content/public/browser/notification_details.h" 27 #include "content/public/browser/notification_details.h"
30 #include "content/public/browser/notification_observer.h" 28 #include "content/public/browser/notification_observer.h"
31 #include "content/public/browser/notification_registrar.h" 29 #include "content/public/browser/notification_registrar.h"
32 #include "content/public/browser/notification_source.h" 30 #include "content/public/browser/notification_source.h"
33 #include "extensions/browser/extension_registry.h" 31 #include "extensions/browser/extension_registry.h"
34 #include "extensions/browser/pref_names.h"
35 #include "grit/theme_resources.h" 32 #include "grit/theme_resources.h"
36 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSAnimation+Duration.h " 33 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSAnimation+Duration.h "
37 34
38 using extensions::Extension; 35 using extensions::Extension;
39 using extensions::ExtensionList; 36 using extensions::ExtensionList;
40 37
41 NSString* const kBrowserActionVisibilityChangedNotification = 38 NSString* const kBrowserActionVisibilityChangedNotification =
42 @"BrowserActionVisibilityChangedNotification"; 39 @"BrowserActionVisibilityChangedNotification";
43 40
44 namespace { 41 namespace {
(...skipping 327 matching lines...) Expand 10 before | Expand all | Expand 10 after
372 if ([button extension] == extension) 369 if ([button extension] == extension)
373 return button; 370 return button;
374 } 371 }
375 NOTREACHED(); 372 NOTREACHED();
376 return nil; 373 return nil;
377 } 374 }
378 375
379 - (CGFloat)savedWidth { 376 - (CGFloat)savedWidth {
380 if (!toolbarModel_) 377 if (!toolbarModel_)
381 return 0; 378 return 0;
382 if (!profile_->GetPrefs()->HasPrefPath(
383 extensions::pref_names::kToolbarSize)) {
384 // Migration code to the new VisibleIconCount pref.
385 // TODO(mpcomplete): remove this at some point.
386 double predefinedWidth = profile_->GetPrefs()->GetDouble(
387 extensions::pref_names::kBrowserActionContainerWidth);
388 if (predefinedWidth != 0) {
389 int iconWidth = kBrowserActionWidth + kBrowserActionButtonPadding;
390 int extraWidth = kChevronWidth;
391 toolbarModel_->SetVisibleIconCount(
392 (predefinedWidth - extraWidth) / iconWidth);
393 }
394 }
395 379
396 int savedButtonCount = toolbarModel_->GetVisibleIconCount(); 380 int savedButtonCount = toolbarModel_->GetVisibleIconCount();
397 if (savedButtonCount < 0 || // all icons are visible 381 if (savedButtonCount < 0 || // all icons are visible
398 static_cast<NSUInteger>(savedButtonCount) > [self buttonCount]) 382 static_cast<NSUInteger>(savedButtonCount) > [self buttonCount])
399 savedButtonCount = [self buttonCount]; 383 savedButtonCount = [self buttonCount];
400 return [self containerWidthWithButtonCount:savedButtonCount]; 384 return [self containerWidthWithButtonCount:savedButtonCount];
401 } 385 }
402 386
403 - (NSPoint)popupPointForBrowserAction:(const Extension*)extension { 387 - (NSPoint)popupPointForBrowserAction:(const Extension*)extension {
404 if (!extensions::ExtensionActionManager::Get(profile_)-> 388 if (!extensions::ExtensionActionManager::Get(profile_)->
(...skipping 481 matching lines...) Expand 10 before | Expand all | Expand 10 after
886 const extensions::ExtensionList& toolbar_items = 870 const extensions::ExtensionList& toolbar_items =
887 toolbarModel_->toolbar_items(); 871 toolbarModel_->toolbar_items();
888 if (index < toolbar_items.size()) { 872 if (index < toolbar_items.size()) {
889 const Extension* extension = toolbar_items[index].get(); 873 const Extension* extension = toolbar_items[index].get();
890 return [buttons_ objectForKey:base::SysUTF8ToNSString(extension->id())]; 874 return [buttons_ objectForKey:base::SysUTF8ToNSString(extension->id())];
891 } 875 }
892 return nil; 876 return nil;
893 } 877 }
894 878
895 @end 879 @end
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/toolbar/browser_actions_container.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698