Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 451053004: change setA/setB labels if viewing actuals vs expectations (Closed)

Created:
6 years, 4 months ago by epoger
Modified:
6 years, 4 months ago
Reviewers:
rmistry
CC:
reviews_skia.org, stephana
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

change setA/setB labels if viewing actuals vs expectations NOTRY=true Committed: https://skia.googlesource.com/skia/+/8d66dd1d4317e84c07c93c023e299e9a88069206

Patch Set 1 : determine default setA_label and setB_label at runtime- still 'setA' and 'setB' #

Patch Set 2 : use section names as default labels if comparing different section names #

Patch Set 3 : add hover-notes to setA and setB column headers #

Messages

Total messages: 5 (0 generated)
epoger
Ravi, PTAL at patchset 3. Patchset 1 didn't change any behavior; it just opened the ...
6 years, 4 months ago (2014-08-08 20:11:18 UTC) #1
rmistry
LGTM
6 years, 4 months ago (2014-08-08 20:33:53 UTC) #2
epoger
The CQ bit was checked by epoger@google.com
6 years, 4 months ago (2014-08-12 15:28:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/451053004/40001
6 years, 4 months ago (2014-08-12 15:28:54 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 15:29:11 UTC) #5
Message was sent while issue was closed.
Change committed as 8d66dd1d4317e84c07c93c023e299e9a88069206

Powered by Google App Engine
This is Rietveld 408576698