Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: gm/rebaseline_server/compare_rendered_pictures_test.py

Issue 451053004: change setA/setB labels if viewing actuals vs expectations (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: add hover-notes to setA and setB column headers Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gm/rebaseline_server/compare_rendered_pictures.py ('k') | gm/rebaseline_server/static/live-view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/rebaseline_server/compare_rendered_pictures_test.py
diff --git a/gm/rebaseline_server/compare_rendered_pictures_test.py b/gm/rebaseline_server/compare_rendered_pictures_test.py
index e761c8a5c2dd37defaa8855e1eed75b8f0892606..6a057d29429c76967cf0d1e8744b4588fb7ad2f4 100755
--- a/gm/rebaseline_server/compare_rendered_pictures_test.py
+++ b/gm/rebaseline_server/compare_rendered_pictures_test.py
@@ -40,30 +40,29 @@ class CompareRenderedPicturesTest(base_unittest.TestCase):
def test_endToEnd(self):
"""Generate two sets of SKPs, run render_pictures over both, and compare
the results."""
- setA_label = 'before_patch'
- setB_label = 'after_patch'
+ setA_subdir = 'before_patch'
+ setB_subdir = 'after_patch'
self._generate_skps_and_run_render_pictures(
- subdir=setA_label, skpdict={
+ subdir=setA_subdir, skpdict={
'changed.skp': 200,
'unchanged.skp': 100,
'only-in-before.skp': 128,
})
self._generate_skps_and_run_render_pictures(
- subdir=setB_label, skpdict={
+ subdir=setB_subdir, skpdict={
'changed.skp': 201,
'unchanged.skp': 100,
'only-in-after.skp': 128,
})
results_obj = compare_rendered_pictures.RenderedPicturesComparisons(
- setA_dirs=[os.path.join(self.temp_dir, setA_label)],
- setB_dirs=[os.path.join(self.temp_dir, setB_label)],
+ setA_dirs=[os.path.join(self.temp_dir, setA_subdir)],
+ setB_dirs=[os.path.join(self.temp_dir, setB_subdir)],
setA_section=gm_json.JSONKEY_ACTUALRESULTS,
setB_section=gm_json.JSONKEY_ACTUALRESULTS,
image_diff_db=imagediffdb.ImageDiffDB(self.temp_dir),
image_base_gs_url='gs://fakebucket/fake/path',
- diff_base_url='/static/generated-images',
- setA_label=setA_label, setB_label=setB_label)
+ diff_base_url='/static/generated-images')
results_obj.get_timestamp = mock_get_timestamp
gm_json.WriteToFile(
@@ -81,8 +80,7 @@ class CompareRenderedPicturesTest(base_unittest.TestCase):
setB_section=gm_json.JSONKEY_ACTUALRESULTS,
image_diff_db=imagediffdb.ImageDiffDB(self.temp_dir),
image_base_gs_url='gs://fakebucket/fake/path',
- diff_base_url='/static/generated-images',
- setA_label='setA', setB_label='setB')
+ diff_base_url='/static/generated-images')
results_obj.get_timestamp = mock_get_timestamp
gm_json.WriteToFile(
« no previous file with comments | « gm/rebaseline_server/compare_rendered_pictures.py ('k') | gm/rebaseline_server/static/live-view.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698