tools/perf/benchmarks/octane.py - Issue 450873002: [Telemetry] Fix Octane on non-rooted devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/octane.py

Issue 450873002: [Telemetry] Fix Octane on non-rooted devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Maintain check when possible Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/benchmarks/octane.py

diff --git a/tools/perf/benchmarks/octane.py b/tools/perf/benchmarks/octane.py

index 16b0bf30bdb5a1c4e8db9c59cadbcf3e0d040938..eba74f1a8dcfbe2d72cfb236430deb4c075176db 100644

--- a/tools/perf/benchmarks/octane.py

+++ b/tools/perf/benchmarks/octane.py

@@ -76,7 +76,9 @@ class _OctaneMeasurement(page_measurement.PageMeasurement):

self._power_metric = power.PowerMetric(browser)

def WillNavigateToPage(self, page, tab):

- if tab.browser.memory_stats['SystemTotalPhysicalMemory'] < 1 * _GB:

+ memory_stats = tab.browser.memory_stats

+ if ('SystemTotalPhysicalMemory' in memory_stats and

+ memory_stats['SystemTotalPhysicalMemory'] < 1 * _GB):

skipBenchmarks = '"zlib"'

else:

skipBenchmarks = ''

« no previous file with comments | « no previous file | no next file » | no next file with comments »