Issue 450763002: [Hotword] Do not open about:voicesearch page in incognito to prevent crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 450763002: [Hotword] Do not open about:voicesearch page in incognito to prevent crash. (Closed)

Created:
6 years, 4 months ago by rpetterson

Modified:
6 years, 4 months ago

Reviewers:
msw

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Hotword] Do not open about:voicesearch page in incognito to prevent crash. Voice search is not available in incognito mode so if prompted to open the about:voicesearch page while in an incognito window, instead redirect and open it in a new tab in the parent profile's current window. This is how other about: pages handle this situation. BUG=400151 TEST=open an incognito window, navigate to about://voicesearch, observe that it opens in a new tab in the parent window and does not crash. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288289

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/ui/browser_navigator.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/450763002/1

6 years, 4 months ago (2014-08-08 00:54:46 UTC) #4

Message was sent while issue was closed.

Change committed as 288289

Expand Messages | Collapse Messages