Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 450763002: [Hotword] Do not open about:voicesearch page in incognito to prevent crash. (Closed)

Created:
6 years, 4 months ago by rpetterson
Modified:
6 years, 4 months ago
Reviewers:
msw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Hotword] Do not open about:voicesearch page in incognito to prevent crash. Voice search is not available in incognito mode so if prompted to open the about:voicesearch page while in an incognito window, instead redirect and open it in a new tab in the parent profile's current window. This is how other about: pages handle this situation. BUG=400151 TEST=open an incognito window, navigate to about://voicesearch, observe that it opens in a new tab in the parent window and does not crash. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/browser_navigator.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
rpetterson
6 years, 4 months ago (2014-08-07 19:59:16 UTC) #1
msw
lgtm w/nits: add TEST= & line breaks in the CL description.
6 years, 4 months ago (2014-08-07 20:30:26 UTC) #2
rpetterson
The CQ bit was checked by rlp@chromium.org
6 years, 4 months ago (2014-08-08 00:07:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/450763002/1
6 years, 4 months ago (2014-08-08 00:54:46 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 09:53:12 UTC) #5
Message was sent while issue was closed.
Change committed as 288289

Powered by Google App Engine
This is Rietveld 408576698