chrome/browser/ui/browser_navigator.cc - Issue 450763002: [Hotword] Do not open about:voicesearch page in incognito to prevent crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_navigator.cc

Issue 450763002: [Hotword] Do not open about:voicesearch page in incognito to prevent crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_navigator.cc

diff --git a/chrome/browser/ui/browser_navigator.cc b/chrome/browser/ui/browser_navigator.cc

index 71bc94225b2d050b3e6e6ac79ce7cdffb2fc6d19..b0961df5d6a65bb2557bdf1a4b4afba565d4d5c8 100644

--- a/chrome/browser/ui/browser_navigator.cc

+++ b/chrome/browser/ui/browser_navigator.cc

@@ -734,7 +734,8 @@ bool IsURLAllowedInIncognito(const GURL& url,

url.host() == chrome::kChromeUIThumbnailHost2 ||

url.host() == chrome::kChromeUIThumbnailListHost ||

url.host() == chrome::kChromeUISuggestionsHost ||

- url.host() == chrome::kChromeUIDevicesHost)) {

+ url.host() == chrome::kChromeUIDevicesHost ||

+ url.host() == chrome::kChromeUIVoiceSearchHost)) {

return false;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »