Move ShouldHideTopVerbatimMatch to components/search

Move ShouldHideTopVerbatimMatch to components/search

To remove chrome/ dependency from AutocompleteResult

BUG=388504
TEST=components_unittest --gtest_filter="ShouldHideTopVerbatimTest.*"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288958

[hashimoto, 2014-08-07 10:29:40]

Please review.

[hashimoto, 2014-08-11 05:19:14]

kmadhusu@, could you take a look at this change?

[kmadhusu, 2014-08-11 16:10:00]

lgtm

[hashimoto, 2014-08-12 00:01:59]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-08-12 00:06:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/450663002/20001

[commit-bot: I haz the power, 2014-08-12 00:17:56]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[commit-bot: I haz the power, 2014-08-12 00:28:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-12 00:28:07]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[hashimoto, 2014-08-12 00:29:45]

Peter, could you review this change as an owner of chrome/browser/autocomplete?

[Peter Kasting, 2014-08-12 02:03:42]

LGTM

https://codereview.chromium.org/450663002/diff/40001/components/search/search.cc
File components/search/search.cc (right):

https://codereview.chromium.org/450663002/diff/40001/components/search/search...
components/search/search.cc:38: const char kHideVerbatimFlagName[] =
"hide_verbatim";
Nit: Define things in the most local scope possible (in this case, in the
function below)

[hashimoto, 2014-08-12 04:43:15]

https://codereview.chromium.org/450663002/diff/40001/components/search/search.cc
File components/search/search.cc (right):

https://codereview.chromium.org/450663002/diff/40001/components/search/search...
components/search/search.cc:38: const char kHideVerbatimFlagName[] =
"hide_verbatim";
On 2014/08/12 02:03:41, Peter Kasting wrote:
> Nit: Define things in the most local scope possible (in this case, in the
> function below)

I guess authors of search.cc are putting these constants in the unnamed
namespace intentionally. (probably to manage constants in one place)
Let me keep this to be consistent with other functions in this file.

[hashimoto, 2014-08-12 05:30:29]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-08-12 05:32:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/450663002/40001

[commit-bot: I haz the power, 2014-08-12 06:26:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[commit-bot: I haz the power, 2014-08-12 14:39:26]

Change committed as 288958