Move ShouldHideTopVerbatimMatch to components/search

components/search/search.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/search/search.h"
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
@@ skipping 17 matching lines @@
 #if defined(OS_IOS)
 const uint64 kEmbeddedPageVersionDefault = 1;
 #elif defined(OS_ANDROID)
 const uint64 kEmbeddedPageVersionDefault = 1;
 // Use this variant to enable EmbeddedSearch SearchBox API in the results page.
 const uint64 kEmbeddedSearchEnabledVersion = 2;
 #else
 const uint64 kEmbeddedPageVersionDefault = 2;
 #endif
 
+const char kHideVerbatimFlagName[] = "hide_verbatim";

[Peter Kasting, 2014/08/12 02:03:41]

Nit: Define things in the most local scope possible (in this case, in the
function below)

[hashimoto, 2014/08/12 04:43:15]

I guess authors of search.cc are putting these constants in the unnamed
namespace intentionally. (probably to manage constants in one place)
Let me keep this to be consistent with other functions in this file.

+
 // Constants for the field trial name and group prefix.
 // Note in M30 and below this field trial was named "InstantExtended" and in
 // M31 was renamed to EmbeddedSearch for clarity and cleanliness.  Since we
 // can't easilly sync up Finch configs with the pushing of this change to
 // Dev & Canary, for now the code accepts both names.
 // TODO(dcblack): Remove the InstantExtended name once M31 hits the Beta
 // channel.
 const char kInstantExtendedFieldTrialName[] = "InstantExtended";
 const char kEmbeddedSearchFieldTrialName[] = "EmbeddedSearch";
 
@@ skipping 88 matching lines @@
 }
 
 // Given a FieldTrialFlags object, returns the boolean value of the provided
 // flag.
 bool GetBoolValueForFlagWithDefault(const std::string& flag,
                                     bool default_value,
                                     const FieldTrialFlags& flags) {
   return !!GetUInt64ValueForFlagWithDefault(flag, default_value ? 1 : 0, flags);
 }
 
+bool ShouldHideTopVerbatimMatch() {
+  FieldTrialFlags flags;
+  return GetFieldTrialInfo(&flags) && GetBoolValueForFlagWithDefault(
+      kHideVerbatimFlagName, false, flags);
+}
+
 }  // namespace chrome