Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 450403003: Remove unnecessary setNeedsCompositingUpdate(CompositingUpdateRebuildTree) (Closed)

Created:
6 years, 4 months ago by abarth-chromium
Modified:
6 years, 4 months ago
Reviewers:
esprehn
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, chrishtr, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, skobes, Ian Vollick, zoltan1
Project:
blink
Visibility:
Public.

Description

Remove unnecessary setNeedsCompositingUpdate(CompositingUpdateRebuildTree) The RenderLayerCompositor can determine whether it needs to rebuild the tree. We don't need to dirty this much state. R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M Source/core/rendering/RenderLayer.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
abarth-chromium
6 years, 4 months ago (2014-08-11 22:26:01 UTC) #1
esprehn
Does adding a new RenderLayer still always cause a rebuild tree later in the pipeline?
6 years, 4 months ago (2014-08-11 22:59:55 UTC) #2
esprehn
lgtm
6 years, 4 months ago (2014-08-11 23:10:52 UTC) #3
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-08-11 23:12:25 UTC) #4
abarth-chromium
On 2014/08/11 at 22:59:55, esprehn wrote: > Does adding a new RenderLayer still always cause ...
6 years, 4 months ago (2014-08-11 23:13:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/450403003/1
6 years, 4 months ago (2014-08-11 23:13:23 UTC) #6
abarth-chromium
6 years, 4 months ago (2014-08-11 23:31:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as 180008 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698