Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Side by Side Diff: Source/core/rendering/RenderLayer.cpp

Issue 450403003: Remove unnecessary setNeedsCompositingUpdate(CompositingUpdateRebuildTree) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 1243 matching lines...) Expand 10 before | Expand all | Expand 10 after
1254 beforeChild->setPreviousSibling(child); 1254 beforeChild->setPreviousSibling(child);
1255 child->setNextSibling(beforeChild); 1255 child->setNextSibling(beforeChild);
1256 ASSERT(beforeChild != child); 1256 ASSERT(beforeChild != child);
1257 } else 1257 } else
1258 setLastChild(child); 1258 setLastChild(child);
1259 1259
1260 child->m_parent = this; 1260 child->m_parent = this;
1261 1261
1262 setNeedsCompositingInputsUpdate(); 1262 setNeedsCompositingInputsUpdate();
1263 1263
1264 // FIXME: Why do we need to explicitly set CompositingUpdateRebuildTree?
1265 compositor()->setNeedsCompositingUpdate(CompositingUpdateRebuildTree);
1266
1267 if (child->stackingNode()->isNormalFlowOnly()) 1264 if (child->stackingNode()->isNormalFlowOnly())
1268 m_stackingNode->dirtyNormalFlowList(); 1265 m_stackingNode->dirtyNormalFlowList();
1269 1266
1270 if (!child->stackingNode()->isNormalFlowOnly() || child->firstChild()) { 1267 if (!child->stackingNode()->isNormalFlowOnly() || child->firstChild()) {
1271 // Dirty the z-order list in which we are contained. The ancestorStackin gContextNode() can be null in the 1268 // Dirty the z-order list in which we are contained. The ancestorStackin gContextNode() can be null in the
1272 // case where we're building up generated content layers. This is ok, si nce the lists will start 1269 // case where we're building up generated content layers. This is ok, si nce the lists will start
1273 // off dirty in that case anyway. 1270 // off dirty in that case anyway.
1274 child->stackingNode()->dirtyStackingContextZOrderLists(); 1271 child->stackingNode()->dirtyStackingContextZOrderLists();
1275 } 1272 }
1276 1273
(...skipping 2468 matching lines...) Expand 10 before | Expand all | Expand 10 after
3745 } 3742 }
3746 } 3743 }
3747 3744
3748 void showLayerTree(const blink::RenderObject* renderer) 3745 void showLayerTree(const blink::RenderObject* renderer)
3749 { 3746 {
3750 if (!renderer) 3747 if (!renderer)
3751 return; 3748 return;
3752 showLayerTree(renderer->enclosingLayer()); 3749 showLayerTree(renderer->enclosingLayer());
3753 } 3750 }
3754 #endif 3751 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698