Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 450293002: Invalidation set features are not skippable. (Closed)

Created:
6 years, 4 months ago by rune
Modified:
6 years, 4 months ago
Reviewers:
chrishtr, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Project:
blink
Visibility:
Public.

Description

Invalidation set features are not skippable. Ids, attributes, tag names, and custom pseudo elements are handled as invalidation set features and not skippable. Should be unnecessary to check for them in isSkippableComponentForInvalidation. R=chrishtr@chromium.org, esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M Source/core/css/RuleFeature.cpp View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rune
6 years, 4 months ago (2014-08-08 13:13:10 UTC) #1
chrishtr
lgtm
6 years, 4 months ago (2014-08-08 16:53:41 UTC) #2
rune
@esprehn?
6 years, 4 months ago (2014-08-13 07:47:16 UTC) #3
esprehn
lgtm
6 years, 4 months ago (2014-08-16 07:51:34 UTC) #4
rune
The CQ bit was checked by rune@opera.com
6 years, 4 months ago (2014-08-18 12:31:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/450293002/1
6 years, 4 months ago (2014-08-18 12:32:50 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-18 13:34:22 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 14:32:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (1) as 180463

Powered by Google App Engine
This is Rietveld 408576698