Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: Source/core/css/RuleFeature.cpp

Issue 450293002: Invalidation set features are not skippable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/RuleFeature.cpp
diff --git a/Source/core/css/RuleFeature.cpp b/Source/core/css/RuleFeature.cpp
index 8b1d9b8a0d97f13acaca239da4a2a95e0e848c91..ec80d685e2b2b42e93d1641e445b7e5e0d2638e3 100644
--- a/Source/core/css/RuleFeature.cpp
+++ b/Source/core/css/RuleFeature.cpp
@@ -44,10 +44,10 @@ namespace blink {
static bool isSkippableComponentForInvalidation(const CSSSelector& selector)
{
- if (selector.match() == CSSSelector::Tag
- || selector.match() == CSSSelector::Id
- || selector.isAttributeSelector())
+ if (selector.match() == CSSSelector::Tag) {
+ ASSERT(selector.tagQName().localName() == starAtom);
return true;
+ }
if (selector.match() == CSSSelector::PseudoElement) {
switch (selector.pseudoType()) {
case CSSSelector::PseudoBefore:
@@ -56,7 +56,8 @@ static bool isSkippableComponentForInvalidation(const CSSSelector& selector)
case CSSSelector::PseudoShadow:
return true;
default:
- return selector.isCustomPseudoElement();
+ ASSERT(!selector.isCustomPseudoElement());
+ return false;
}
}
if (selector.match() != CSSSelector::PseudoClass)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698