Issue 450029: linux: don't try to create plugin container if view_ is NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 450029: linux: don't try to create plugin container if view_ is NULL (Closed)

Created:
11 years ago by piman

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

linux: don't try to create plugin container if view_ is NULL This can only happen for extensions with delay-initialized RenderWidgetHost. BUG=28715 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33434

Patch Set 1 #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	chrome/browser/renderer_host/render_widget_host.cc	View		1 chunk	+9 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

11 years ago (2009-12-01 06:29:15 UTC) #2

LGTM

http://codereview.chromium.org/450029/diff/1/2
File chrome/browser/renderer_host/render_widget_host.cc (right):

http://codereview.chromium.org/450029/diff/1/2#newcode890
chrome/browser/renderer_host/render_widget_host.cc:890: // support plugins in
that case.
Can you add a NOTIMPLEMENTED in the "else" case?

Expand Messages | Collapse Messages