Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: chrome/browser/renderer_host/render_widget_host.cc

Issue 450029: linux: don't try to create plugin container if view_ is NULL (Closed)
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/render_widget_host.cc
diff --git a/chrome/browser/renderer_host/render_widget_host.cc b/chrome/browser/renderer_host/render_widget_host.cc
index 7954a2d821083971c56aca163a425b821fe514b3..73d4718816487f15b206d5807078a068647d5471 100644
--- a/chrome/browser/renderer_host/render_widget_host.cc
+++ b/chrome/browser/renderer_host/render_widget_host.cc
@@ -885,11 +885,18 @@ void RenderWidgetHost::OnMsgImeUpdateStatus(int control,
#if defined(OS_LINUX)
void RenderWidgetHost::OnMsgCreatePluginContainer(gfx::PluginWindowHandle id) {
- view_->CreatePluginContainer(id);
+ // TODO(piman): view_ can only be NULL with delayed view creation in
+ // extensions (see ExtensionHost::CreateRenderViewSoon). Figure out how to
+ // support plugins in that case.
Evan Martin 2009/12/01 06:29:15 Can you add a NOTIMPLEMENTED in the "else" case?
+ if (view_) {
+ view_->CreatePluginContainer(id);
+ }
}
void RenderWidgetHost::OnMsgDestroyPluginContainer(gfx::PluginWindowHandle id) {
- view_->DestroyPluginContainer(id);
+ if (view_) {
+ view_->DestroyPluginContainer(id);
+ }
}
#elif defined(OS_MACOSX)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698