Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc

Issue 449973002: Use data reduction proxy when managed proxy config returns direct (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-uma-in-proxy-service
Patch Set: Addressed comment and nit Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc b/components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc
index a8536687ef9e95c8010b904d0c78df63bbb3b17e..09f5d2c43e7eccfa675c5a80a891d85f887d288c 100644
--- a/components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc
@@ -94,7 +94,8 @@ DataReductionProxySettings::DataReductionProxySettings(
unreachable_(false),
prefs_(NULL),
local_state_prefs_(NULL),
- url_request_context_getter_(NULL) {
+ url_request_context_getter_(NULL),
+ configurator_(NULL) {
DCHECK(params);
params_.reset(params);
}
@@ -149,11 +150,11 @@ void DataReductionProxySettings::InitDataReductionProxySettings(
PrefService* prefs,
PrefService* local_state_prefs,
net::URLRequestContextGetter* url_request_context_getter,
- scoped_ptr<DataReductionProxyConfigurator> configurator) {
+ DataReductionProxyConfigurator* configurator) {
InitDataReductionProxySettings(prefs,
local_state_prefs,
url_request_context_getter);
- SetProxyConfigurator(configurator.Pass());
+ SetProxyConfigurator(configurator);
}
void DataReductionProxySettings::SetOnDataReductionEnabledCallback(
@@ -163,9 +164,9 @@ void DataReductionProxySettings::SetOnDataReductionEnabledCallback(
}
void DataReductionProxySettings::SetProxyConfigurator(
- scoped_ptr<DataReductionProxyConfigurator> configurator) {
+ DataReductionProxyConfigurator* configurator) {
DCHECK(configurator);
- configurator_ = configurator.Pass();
+ configurator_ = configurator;
}
bool DataReductionProxySettings::IsDataReductionProxyEnabled() {

Powered by Google App Engine
This is Rietveld 408576698