chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc - Issue 449973002: Use data reduction proxy when managed proxy config returns direct

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc

Issue 449973002: Use data reduction proxy when managed proxy config returns direct (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-uma-in-proxy-service

Patch Set: Addressed comment and nit Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h ('K') | « chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h ('k') | chrome/browser/profiles/profile_impl.cc » ('j') | net/base/network_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc

diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc

index 19ac6f1f21c0cf4c1e544d96325a95373954fc82..26be2de2cd7dc939dba07a2f3d4b57d189009c0c 100644

--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc

+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc

@@ -30,12 +30,11 @@ DataReductionProxyChromeSettings::~DataReductionProxyChromeSettings() {

}

void DataReductionProxyChromeSettings::InitDataReductionProxySettings(

- scoped_ptr<data_reduction_proxy::DataReductionProxyConfigurator>

- configurator,

+ data_reduction_proxy::DataReductionProxyConfigurator* configurator,

PrefService* profile_prefs,

PrefService* local_state_prefs,

net::URLRequestContextGetter* request_context) {

- SetProxyConfigurator(configurator.Pass());

+ SetProxyConfigurator(configurator);

DataReductionProxySettings::InitDataReductionProxySettings(

profile_prefs,

local_state_prefs,