Form submitted from JS should not submit double values

Form submitted from JS should not submit double values

Jquery validation adds hidden element and removes it after JS submit handler. In blink, it was resulting in extra value being submitted.

This patch reverts changes of r170520, r171008 and r169158.

r169158, changes are not needed anymore due to formcreate called from scheduleformsubmission.
r170520 and r171008 removed variable which control double form submission when from JS and normal submission.

Also fixes the issue with bug357101, which CL170520 fixed, by keeping validateInteractive independent of m_isSubmittingOrInUserJSSubmitEvent variable.

R=tkent, keishi
BUG=378949
TEST=Check add remove element from inside user JS event handler, does not lead to double value submission.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179776

[Habib Virji, 2014-08-07 12:58:28]

Fixes the issue with form submission from User's JS onsubmit and normal submit
handler.

[tkent, 2014-08-08 00:49:33]

lgtm.

Thank you for fixing this.

https://codereview.chromium.org/449823003/diff/1/LayoutTests/fast/forms/submi...
File LayoutTests/fast/forms/submit-add-remove-element.html (right):

https://codereview.chromium.org/449823003/diff/1/LayoutTests/fast/forms/submi...
LayoutTests/fast/forms/submit-add-remove-element.html:38: }
nit: Need ';' because this is substitution expression, not function declaration.

https://codereview.chromium.org/449823003/diff/1/LayoutTests/fast/forms/submi...
LayoutTests/fast/forms/submit-add-remove-element.html:42: }
Ditto.

[tkent, 2014-08-08 00:49:37]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-08-08 00:51:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/habib.virji@samsung.com/449823003/1

[commit-bot: I haz the power, 2014-08-08 02:14:36]

Change committed as 179776

[Habib Virji, 2014-08-08 08:18:14]

On 2014/08/08 00:49:33, tkent wrote:
> lgtm.
> 
> Thank you for fixing this.
> 
>
https://codereview.chromium.org/449823003/diff/1/LayoutTests/fast/forms/submi...
> File LayoutTests/fast/forms/submit-add-remove-element.html (right):
> 
>
https://codereview.chromium.org/449823003/diff/1/LayoutTests/fast/forms/submi...
> LayoutTests/fast/forms/submit-add-remove-element.html:38: }
> nit: Need ';' because this is substitution expression, not function
declaration.
> 
>
https://codereview.chromium.org/449823003/diff/1/LayoutTests/fast/forms/submi...
> LayoutTests/fast/forms/submit-add-remove-element.html:42: }
> Ditto.

Since this is already committed, is it okay to submit it as part of other CL?

[tkent, 2014-08-08 08:21:18]

On 2014/08/08 08:18:14, Habib Virji wrote:
> 
> Since this is already committed, is it okay to submit it as part of other CL?

No.