Source/core/html/HTMLFormElement.h - Issue 449823003: Form submitted from JS should not submit double values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormElement.h

Issue 449823003: Form submitted from JS should not submit double values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/submit-add-remove-element.html ('K') | « LayoutTests/fast/forms/submit-add-remove-element-expected.txt ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLFormElement.h

diff --git a/Source/core/html/HTMLFormElement.h b/Source/core/html/HTMLFormElement.h

index 4eb9ff1e420735ee13d6907221a5389a04a23276..e4bf3838a1ea693dd1a5ed08136100ddf63eac96 100644

--- a/Source/core/html/HTMLFormElement.h

+++ b/Source/core/html/HTMLFormElement.h

@@ -178,6 +178,8 @@ private:

bool m_didFinishParsingChildren;

bool m_wasUserSubmitted;

+ bool m_isSubmittingOrInUserJSSubmitEvent;

+ bool m_shouldSubmit;

bool m_isInResetFunction;