Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 449813002: Perform full gcs when context disposals happen too frequent. (Closed)

Created:
6 years, 4 months ago by Hannes Payer (out of office)
Modified:
6 years, 4 months ago
CC:
Paweł Hajdan Jr., v8-dev
Project:
v8
Visibility:
Public.

Description

Perform full gcs when context disposals happen too frequent. Removed context disposal logic from IdleNotification. BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -45 lines) Patch
M include/v8.h View 1 chunk +3 lines, -5 lines 0 comments Download
M src/api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/heap.h View 2 chunks +7 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 chunks +24 lines, -34 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
6 years, 4 months ago (2014-08-07 09:11:19 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/449813002/diff/60001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/449813002/diff/60001/src/heap/heap.cc#newcode4328 src/heap/heap.cc:4328: CollectAllGarbage(kReduceMemoryFootprintMask, this is a somewhat new behavior, because ...
6 years, 4 months ago (2014-08-07 09:14:51 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/449813002/diff/60001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/449813002/diff/60001/src/heap/heap.cc#newcode4328 src/heap/heap.cc:4328: CollectAllGarbage(kReduceMemoryFootprintMask, On 2014/08/07 09:14:51, jochen (slow - soon OOO) ...
6 years, 4 months ago (2014-08-07 10:53:30 UTC) #3
Hannes Payer (out of office)
6 years, 4 months ago (2014-08-07 12:17:00 UTC) #4
A *dispose storm* increases jank significantly. This may happen on regular
webpages.

Powered by Google App Engine
This is Rietveld 408576698