Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Unified Diff: src/heap/heap.h

Issue 449813002: Perform full gcs when context disposals happen too frequent. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | src/heap/heap.cc » ('j') | src/heap/heap.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index 528ef4d517e2d5536f639418aeec85ab30137f16..07361040922fce1eba0f6be29efa9b680587b301 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -754,7 +754,7 @@ class Heap {
bool IsHeapIterable();
// Notify the heap that a context has been disposed.
- int NotifyContextDisposed();
+ void NotifyContextDisposed();
inline void increment_scan_on_scavenge_pages() {
scan_on_scavenge_pages_++;
@@ -1462,13 +1462,16 @@ class Heap {
int always_allocate_scope_depth_;
- // For keeping track of context disposals.
- int contexts_disposed_;
-
int global_ic_age_;
bool flush_monomorphic_ics_;
+ // If context disposals happen at a high rate, we do a full gc in between
+ // context disposal.
+ // TODO(hpayer): We should get rid of that mode.
+ static const int kNotifyContextDisposedFullGCLimitInMS = 1000;
+ double last_notify_context_disposed_;
+
int scan_on_scavenge_pages_;
NewSpace new_space_;
« no previous file with comments | « src/api.cc ('k') | src/heap/heap.cc » ('j') | src/heap/heap.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698