Issue 449743002: Remove unnecessary strings from SSLErrorInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 449743002: Remove unnecessary strings from SSLErrorInfo (Closed)

Created:
6 years, 4 months ago by felt

Modified:
6 years, 4 months ago

Reviewers:
palmer

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Remove unnecessary strings from SSLErrorInfo BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288536

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -213 lines)			Patch
M	chrome/app/chromium_strings.grd	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View		4 chunks	+0 lines, -98 lines	0 comments	Download
M	chrome/app/google_chrome_strings.grd	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ssl/ssl_error_info.h	View		1 chunk	+2 lines, -17 lines	0 comments	Download
M	chrome/browser/ssl/ssl_error_info.cc	View		5 chunks	+7 lines, -92 lines	0 comments	Download

Total messages: 5 (0 generated)

felt

palmer, PTAL. Doing the promised cleanup. :) After this, I can probably move some logic ...

6 years, 4 months ago (2014-08-07 04:42:31 UTC) #1

palmer

LGTM! Chances are good I'll have to rebase https://codereview.chromium.org/416403006/ again when this lands. And this ...

6 years, 4 months ago (2014-08-08 23:25:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/449743002/20001

6 years, 4 months ago (2014-08-08 23:28:39 UTC) #4

Message was sent while issue was closed.

Change committed as 288536