Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Unified Diff: chrome/browser/ui/webui/help/help_handler.h

Issue 449623003: Integrate About page into Settings for Chrome OS settings in a window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: simplify Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/help/help_handler.h
diff --git a/chrome/browser/ui/webui/help/help_handler.h b/chrome/browser/ui/webui/help/help_handler.h
index 812f40b1990a879b8364d81b9bff1c77052d3258..c64c385afb2a82006c3748e6454d5286ce9474c6 100644
--- a/chrome/browser/ui/webui/help/help_handler.h
+++ b/chrome/browser/ui/webui/help/help_handler.h
@@ -9,17 +9,25 @@
#include "base/compiler_specific.h"
#include "base/memory/weak_ptr.h"
+#include "base/strings/string16.h"
#include "chrome/browser/ui/webui/help/version_updater.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
#include "content/public/browser/web_ui_message_handler.h"
#if defined(OS_CHROMEOS)
+#include "base/task/cancelable_task_tracker.h"
#include "chrome/browser/chromeos/version_loader.h"
#endif // defined(OS_CHROMEOS)
+namespace base {
+class DictionaryValue;
+class ListValue;
+}
+
namespace content {
-class WebUIDataSource;
+class NotificationDetails;
+class NotificationSource;
}
Dan Beam 2014/08/13 17:03:18 don't forward OVERRIDE methods
michaelpg 2014/08/13 20:17:51 Done.
// WebUI message handler for the help page.
@@ -32,8 +40,8 @@ class HelpHandler : public content::WebUIMessageHandler,
// WebUIMessageHandler implementation.
virtual void RegisterMessages() OVERRIDE;
- // Fills |source| with string values for the UI.
- void GetLocalizedValues(content::WebUIDataSource* source);
+ // Adds string values for the UI to |localized_strings|.
+ static void GetLocalizedValues(base::DictionaryValue* localized_strings);
// NotificationObserver implementation.
virtual void Observe(int type, const content::NotificationSource& source,

Powered by Google App Engine
This is Rietveld 408576698