Chromium Code Reviews| Index: chrome/browser/resources/help/help_page.js |
| diff --git a/chrome/browser/resources/help/help_page.js b/chrome/browser/resources/help/help_page.js |
| index 10a1807a93a813abd2386e450a635a8c2ad52c0b..efd67923440628d4f11c179cd3587bb09d9cfdea 100644 |
| --- a/chrome/browser/resources/help/help_page.js |
| +++ b/chrome/browser/resources/help/help_page.js |
| @@ -11,8 +11,9 @@ cr.define('help', function() { |
| * confusion with generic AboutUI (about:memory, about:sandbox, etc.). |
| */ |
| function HelpPage() { |
| - Page.call(this, 'help', loadTimeData.getString('aboutTitle'), |
| - 'help-page'); |
| + var id = loadTimeData.valueExists('aboutOverlayTabTitle') ? |
| + 'aboutOverlayTabTitle' : 'aboutTitle'; |
| + Page.call(this, 'help', loadTimeData.getString(id), 'help-page'); |
| } |
| cr.addSingletonGetter(HelpPage); |
| @@ -114,7 +115,7 @@ cr.define('help', function() { |
| } |
| $('change-channel').onclick = function() { |
| - PageManager.showPageByName('channel-change-page', false); |
| + PageManager.showPageByName('channel-change-page'); |
| }; |
| var channelChangeDisallowedError = document.createElement('div'); |
| @@ -143,6 +144,12 @@ cr.define('help', function() { |
| chrome.send('onPageLoaded'); |
| }, |
| + /** @override */ |
| + didClosePage: function() { |
| + if ($('more-info-container').classList.contains('visible')) |
| + this.toggleMoreInfo_(); |
|
Dan Beam
2014/08/13 17:03:18
nit: i'd make a setMoreInfoVisible_ and use it her
michaelpg
2014/08/13 20:17:51
Done.
|
| + }, |
| + |
| /** |
| * Toggles the visible state of the 'More Info' section. |
| * @private |