ui/webui/resources/js/cr/ui/page_manager/page.js - Issue 449623003: Integrate About page into Settings for Chrome OS settings in a window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/page_manager/page.js

Issue 449623003: Integrate About page into Settings for Chrome OS settings in a window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix tests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/help/help_utils.cc ('K') | « chrome/common/chrome_switches.cc ('k') | ui/webui/resources/js/cr/ui/page_manager/page_manager.js » ('j') | ui/webui/resources/js/cr/ui/page_manager/page_manager.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/js/cr/ui/page_manager/page.js

diff --git a/ui/webui/resources/js/cr/ui/page_manager/page.js b/ui/webui/resources/js/cr/ui/page_manager/page.js

index b9d92593c7ec8638dc32cf45613992e5185d296d..ae74047794502c54b832bd6dc18bb779bfdea2e5 100644

--- a/ui/webui/resources/js/cr/ui/page_manager/page.js

+++ b/ui/webui/resources/js/cr/ui/page_manager/page.js

@@ -66,6 +66,22 @@ cr.define('cr.ui.pageManager', function() {

initializePage: function() {},

/**

+ * Called when a page becomes visible.

+ */

+ didShowPage: function() {},

Dan Beam 2014/08/13 02:50:46 i'd do this separately

michaelpg 2014/08/13 08:12:11 ok, removed.

+ /**

+ * Called when a page will be hidden, i.e., when a different root page is

+ * about to be shown.

+ */

+ willHidePage: function() {},

+ /**

+ * Called when an overlay is closed.

+ */

+ didClosePage: function() {},

+ /**

* Sets focus on the first focusable element. Override for a custom focus

* strategy.