Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6735)

Unified Diff: chrome/common/chrome_switches.cc

Issue 449623003: Integrate About page into Settings for Chrome OS settings in a window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix tests Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/chrome_switches.cc
diff --git a/chrome/common/chrome_switches.cc b/chrome/common/chrome_switches.cc
index 17c6b950fae454c13b15bebf4ad5a3d79b72c07b..816292f86221f7b429a3faecdcd8d203f19a26df 100644
--- a/chrome/common/chrome_switches.cc
+++ b/chrome/common/chrome_switches.cc
@@ -201,6 +201,10 @@ const char kDiagnosticsFormat[] = "diagnostics-format";
// Tells the diagnostics mode to do the requested recovery step(s).
const char kDiagnosticsRecovery[] = "diagnostics-recovery";
+// When kEnableSettingsWindow is used, About is shown as an overlay in Settings
+// instead of as a separate page, unless this flag is specified.
+const char kDisableAboutInSettings[] = "disable-about-in-settings";
+
// Disables the experimental asynchronous DNS client.
const char kDisableAsyncDns[] = "disable-async-dns";
@@ -1349,6 +1353,12 @@ const char kDebugPrint[] = "debug-print";
const char kFileManagerExtensionPath[] = "filemgr-ext-path";
#endif
+bool AboutInSettingsEnabled() {
+ return SettingsWindowEnabled() &&
+ !CommandLine::ForCurrentProcess()->HasSwitch(
+ ::switches::kDisableAboutInSettings);
+}
+
bool SettingsWindowEnabled() {
#if defined(OS_CHROMEOS)
return !CommandLine::ForCurrentProcess()->HasSwitch(

Powered by Google App Engine
This is Rietveld 408576698