Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 449603002: Remove dummy_results from record_wpr (Closed)

Created:
6 years, 4 months ago by ariblue
Modified:
6 years, 4 months ago
Reviewers:
nednguyen, chrishenry
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove dummy_results from record_wpr BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287889

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M tools/telemetry/telemetry/page/record_wpr.py View 3 chunks +2 lines, -8 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
ariblue
6 years, 4 months ago (2014-08-06 18:21:11 UTC) #1
chrishenry
lgtm
6 years, 4 months ago (2014-08-06 18:25:17 UTC) #2
nednguyen
lgtm https://codereview.chromium.org/449603002/diff/1/tools/telemetry/telemetry/page/record_wpr.py File tools/telemetry/telemetry/page/record_wpr.py (left): https://codereview.chromium.org/449603002/diff/1/tools/telemetry/telemetry/page/record_wpr.py#oldcode68 tools/telemetry/telemetry/page/record_wpr.py:68: dummy_results = page_test_results.PageTestResults() Thought I removed this in ...
6 years, 4 months ago (2014-08-06 18:47:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ariblue@google.com/449603002/1
6 years, 4 months ago (2014-08-06 18:49:07 UTC) #4
ariblue
https://codereview.chromium.org/449603002/diff/1/tools/telemetry/telemetry/page/record_wpr.py File tools/telemetry/telemetry/page/record_wpr.py (left): https://codereview.chromium.org/449603002/diff/1/tools/telemetry/telemetry/page/record_wpr.py#oldcode68 tools/telemetry/telemetry/page/record_wpr.py:68: dummy_results = page_test_results.PageTestResults() On 2014/08/06 18:47:25, nednguyen wrote: > ...
6 years, 4 months ago (2014-08-06 18:50:12 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 23:10:18 UTC) #6
Message was sent while issue was closed.
Change committed as 287889

Powered by Google App Engine
This is Rietveld 408576698