Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: tools/telemetry/telemetry/page/record_wpr.py

Issue 449603002: Remove dummy_results from record_wpr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/record_wpr.py
diff --git a/tools/telemetry/telemetry/page/record_wpr.py b/tools/telemetry/telemetry/page/record_wpr.py
index 04f1a7c2e35ea3cf0843626facd73d0777005525..ba25594793ac7285bdafd67c1288393fc0ec5e2d 100755
--- a/tools/telemetry/telemetry/page/record_wpr.py
+++ b/tools/telemetry/telemetry/page/record_wpr.py
@@ -16,7 +16,6 @@ from telemetry.page import page_set
from telemetry.page import page_test
from telemetry.page import profile_creator
from telemetry.page import test_expectations
-from telemetry.results import page_test_results
from telemetry.results import results_options
@@ -62,14 +61,9 @@ class RecorderPageTest(page_test.PageTest): # pylint: disable=W0223
# speed index metric.
time.sleep(3)
- # When running record_wpr, results is a GTestTestResults, so we create a
- # dummy PageTestResults that implements the functions we use.
- # TODO(chrishenry): Fix the need for a dummy_results object.
- dummy_results = page_test_results.PageTestResults()
nednguyen 2014/08/06 18:47:25 Thought I removed this in the page_measurement_res
ariblue 2014/08/06 18:50:11 Acknowledged. No worries.
-
if self.page_test:
self._action_name_to_run = self.page_test.action_name_to_run
- self.page_test.RunPage(page, tab, dummy_results)
+ self.page_test.RunPage(page, tab, results)
return
should_reload = False
@@ -82,7 +76,7 @@ class RecorderPageTest(page_test.PageTest): # pylint: disable=W0223
if should_reload:
self.RunNavigateSteps(page, tab)
self._action_name_to_run = action_name
- super(RecorderPageTest, self).RunPage(page, tab, dummy_results)
+ super(RecorderPageTest, self).RunPage(page, tab, results)
should_reload = True
def RunNavigateSteps(self, page, tab):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698