Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 449293002: Don't try to strip NoneType expect_dirs (Closed)

Created:
6 years, 4 months ago by agable
Modified:
6 years, 4 months ago
Reviewers:
iannucci, martiniss
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/testing/expect_tests@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M expect_tests/type_definitions.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
agable
6 years, 4 months ago (2014-08-08 00:17:44 UTC) #1
martiniss
lgtm Can't commit though; need a real committers LGTM :/
6 years, 4 months ago (2014-08-08 00:32:03 UTC) #2
iannucci
lgtm
6 years, 4 months ago (2014-08-08 00:40:12 UTC) #3
agable
Committed patchset #1 manually as a210eb7 (presubmit successful).
6 years, 4 months ago (2014-08-08 00:51:17 UTC) #4
iannucci
6 years, 4 months ago (2014-08-08 01:05:16 UTC) #5
Message was sent while issue was closed.
On 2014/08/08 00:51:17, agable wrote:
> Committed patchset #1 manually as a210eb7 (presubmit successful).

OH, should have bumped version. Oh well.

Powered by Google App Engine
This is Rietveld 408576698