expect_tests/type_definitions.py - Issue 449293002: Don't try to strip NoneType expect_dirs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: expect_tests/type_definitions.py

Issue 449293002: Don't try to strip NoneType expect_dirs (Closed) Base URL: https://chromium.googlesource.com/infra/testing/expect_tests@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: expect_tests/type_definitions.py

diff --git a/expect_tests/type_definitions.py b/expect_tests/type_definitions.py

index 2ec7fcea7f0a8098f2050f286209868727ded2dd..0e9fb1a66d8afdd78faadb8f736bc382c23c8cd2 100644

--- a/expect_tests/type_definitions.py

+++ b/expect_tests/type_definitions.py

@@ -188,7 +188,8 @@ class Test(_Test):

f.func_code.co_firstlineno,

f.func_code.co_name))

- expect_dir = expect_dir.rstrip('/')

+ if expect_dir:

+ expect_dir = expect_dir.rstrip('/')

return super(Test, cls).__new__(cls, name, func_call, expect_dir,

expect_base, ext, covers, breakpoints)

« no previous file with comments | « no previous file | no next file » | no next file with comments »