Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 449273002: Along with sending the SCUP message, this CL includes small fixes which (Closed)

Created:
6 years, 4 months ago by ramant (doing other things)
Modified:
6 years, 4 months ago
Reviewers:
wtc, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, rjshade
Base URL:
https://chromium.googlesource.com/chromium/src.git@Trigger_QUIC_tracegraf_72571464
Project:
chromium
Visibility:
Public.

Description

Along with sending the SCUP message, this CL includes small fixes which allow messages to be sent on the crypto stream after handshake has completed. This includes disabling HANDSHAKE_MODE in the sent packet manager after the handshake is confirmed, and stopping processing of handshake packets once we switch to forward secure and can no longer decrypt them in crypto_test_utils. Without a version bump, out of date clients will tear down the connection if they get a SCUP message from the server. QUIC_VERSION_22. Send a new source-address token when crypto handshake completes. Merge internal change: 72652054 R=rch@chromium.org, wtc@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -23 lines) Patch
M net/quic/crypto/crypto_handshake.h View 2 chunks +8 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_handshake.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 1 chunk +6 lines, -1 line 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 3 chunks +9 lines, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 4 chunks +48 lines, -10 lines 0 comments Download
M net/quic/quic_connection.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_crypto_server_stream.h View 3 chunks +40 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 3 chunks +52 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_stream.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_stream.cc View 1 chunk +7 lines, -1 line 0 comments Download
M net/quic/quic_protocol.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 2 chunks +8 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ramant (doing other things)
6 years, 4 months ago (2014-08-07 23:20:51 UTC) #1
ramant (doing other things)
On 2014/08/07 23:20:51, ramant wrote: Please see https://codereview.chromium.org/453663002 which fixes use after free bug.
6 years, 4 months ago (2014-08-07 23:47:15 UTC) #2
Ryan Hamilton
6 years, 4 months ago (2014-08-08 03:47:56 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698