Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 44923002: Added GLib/DBus workaround to runtest.py under --do-dbus-workaround option. (Closed)

Created:
7 years, 1 month ago by Ken Russell (switch to Gerrit)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org, iannucci, agable, bajones, Zhenyao Mo, ccameron, jln (very slow on Chromium), Jorge Lucangeli Obes
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Added GLib/DBus workaround to runtest.py under --do-dbus-workaround option. It's likely we'll want to do this on all the bots and just remove this command line argument altogether, but I'm concerned about destabilizing the existing bots that don't reboot between each run. For the moment, use this argument only on the GPU bots. It's known to be needed generally, and not specifically for Telemetry tests, due to failures like this one in content_gl_tests: http://build.chromium.org/p/chromium.webkit/builders/GPU%20Linux%20%28dbg%29%20%28NVIDIA%29/builds/20405/steps/content_gl_tests/logs/stdio BUG=309093 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=231085

Patch Set 1 #

Total comments: 16

Patch Set 2 : Addressed stip's review feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -6 lines) Patch
M scripts/slave/recipe_modules/chromium/api.py View 1 4 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/gpu/api.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu.py View 1 3 chunks +5 lines, -3 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/linux_debug.json View 1 8 chunks +8 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/linux_debug_blink.json View 1 8 chunks +8 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/linux_debug_tryserver.json View 1 8 chunks +8 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/linux_release.json View 1 9 chunks +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/linux_release_blink.json View 1 9 chunks +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/linux_release_tryserver.json View 1 9 chunks +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/mac_debug.json View 1 8 chunks +8 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/mac_debug_blink.json View 1 8 chunks +8 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/mac_debug_tryserver.json View 1 8 chunks +8 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/mac_release.json View 1 9 chunks +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/mac_release_blink.json View 1 9 chunks +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/mac_release_git.json View 1 9 chunks +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/mac_release_tryserver.json View 1 9 chunks +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/mac_release_tryserver_blink.json View 1 9 chunks +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/win_debug.json View 1 8 chunks +8 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/win_debug_blink.json View 1 8 chunks +8 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/win_debug_tryserver.json View 1 8 chunks +8 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/win_release.json View 1 9 chunks +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/win_release_blink.json View 1 9 chunks +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu.expected/win_release_tryserver.json View 1 9 chunks +9 lines, -0 lines 0 comments Download
M scripts/slave/runtest.py View 1 3 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
7 years, 1 month ago (2013-10-25 17:51:01 UTC) #1
ghost stip (do not use)
generally prefer to call this spawn-dbus or launch-dbus instead of 'dbusworkaround' https://codereview.chromium.org/44923002/diff/1/scripts/slave/runtest.py File scripts/slave/runtest.py (right): ...
7 years, 1 month ago (2013-10-25 18:41:27 UTC) #2
Ken Russell (switch to Gerrit)
Thanks for your review. All feedback addressed. https://codereview.chromium.org/44923002/diff/1/scripts/slave/runtest.py File scripts/slave/runtest.py (right): https://codereview.chromium.org/44923002/diff/1/scripts/slave/runtest.py#newcode88 scripts/slave/runtest.py:88: def _DoDBusWorkaround(): ...
7 years, 1 month ago (2013-10-25 19:07:12 UTC) #3
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/44923002/diff/1/scripts/slave/runtest.py File scripts/slave/runtest.py (right): https://codereview.chromium.org/44923002/diff/1/scripts/slave/runtest.py#newcode109 scripts/slave/runtest.py:109: pass On 2013/10/25 19:07:12, Ken Russell wrote: > On ...
7 years, 1 month ago (2013-10-25 19:12:16 UTC) #4
ghost stip (do not use)
lgtm
7 years, 1 month ago (2013-10-25 19:31:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/44923002/60001
7 years, 1 month ago (2013-10-25 19:31:16 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-10-25 19:32:24 UTC) #7
Message was sent while issue was closed.
Change committed as 231085

Powered by Google App Engine
This is Rietveld 408576698