Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 44923002: Added GLib/DBus workaround to runtest.py under --do-dbus-workaround option. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Addressed stip's review feedback. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/gpu/api.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium/api.py
diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py
index 581755ca8c335f9905015e27c91e86cd6cb545a7..1495eea8e42c55140bd52a899fdbaa35d08df65f 100644
--- a/scripts/slave/recipe_modules/chromium/api.py
+++ b/scripts/slave/recipe_modules/chromium/api.py
@@ -47,7 +47,7 @@ class ChromiumApi(recipe_api.RecipeApi):
results_url=None, perf_dashboard_id=None, test_type=None,
generate_json_file=False, results_directory=None,
build_number=None, builder_name=None, python_mode=False,
- **kwargs):
+ spawn_dbus=False, **kwargs):
"""Return a runtest.py invocation."""
args = args or []
assert isinstance(args, list)
@@ -83,6 +83,8 @@ class ChromiumApi(recipe_api.RecipeApi):
full_args.append('--builder-name=%s' % builder_name)
if ext == '.py' or python_mode:
full_args.append('--run-python-script')
+ if spawn_dbus:
+ full_args.append('--spawn-dbus')
full_args.append(test)
full_args.extend(args)
@@ -97,7 +99,7 @@ class ChromiumApi(recipe_api.RecipeApi):
)
def run_telemetry_test(self, runner, test, name='', args=None,
- results_directory=''):
+ results_directory='', spawn_dbus=False):
# Choose a reasonable default for the location of the sandbox binary
# on the bots.
env = {}
@@ -135,6 +137,7 @@ class ChromiumApi(recipe_api.RecipeApi):
build_number=self.m.properties['buildnumber'],
builder_name=self.m.properties['buildername'],
python_mode=True,
+ spawn_dbus=spawn_dbus,
env=env)
def runhooks(self, **kwargs):
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/gpu/api.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698