Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 449063003: Revert 286239 "Reland r285211: "Debugging RawChannelWin: replace..." (Closed)

Created:
6 years, 4 months ago by yzshen1
Modified:
6 years, 4 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 286239 "Reland r285211: "Debugging RawChannelWin: replace..." > Reland r285211: "Debugging RawChannelWin: replace DCHECK with CHECK and record write stats." > > But clang-formatted (and after the changed files were clang-formatted). > This should be reverted on the same schedule as the original change (no > later than August 1, 2014). > > > Debugging RawChannelWin: replace DCHECK with CHECK and record write stats. > > > > This is a temp change for debugging purpose. It should be reverted once > > we fix the issue or find out the change doesn't reveal anything. (No later than Aug 1, 2014.) > > > > BUG=385795 > > TEST=None > > BUG=385795 > TBR=yzshen@chromium.org > > Review URL: https://codereview.chromium.org/430473004 TBR=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288092

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -174 lines) Patch
M trunk/src/mojo/system/raw_channel.cc View 20 chunks +34 lines, -34 lines 0 comments Download
M trunk/src/mojo/system/raw_channel_win.cc View 19 chunks +48 lines, -140 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
yzshen1
6 years, 4 months ago (2014-08-07 17:25:02 UTC) #1
yzshen1
6 years, 4 months ago (2014-08-07 17:25:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r288092.

Powered by Google App Engine
This is Rietveld 408576698