Issue 430473004: Reland r285211: "Debugging RawChannelWin: replace DCHECK with CHECK and record write stats."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 430473004: Reland r285211: "Debugging RawChannelWin: replace DCHECK with CHECK and record write stats." (Closed)

Created:
6 years, 4 months ago by viettrungluu

Modified:
6 years, 4 months ago

Reviewers:
yzshen1

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Reland r285211: "Debugging RawChannelWin: replace DCHECK with CHECK and record write stats." But clang-formatted (and after the changed files were clang-formatted). This should be reverted on the same schedule as the original change (no later than August 1, 2014). > Debugging RawChannelWin: replace DCHECK with CHECK and record write stats. > > This is a temp change for debugging purpose. It should be reverted once > we fix the issue or find out the change doesn't reveal anything. (No later than Aug 1, 2014.) > > BUG=385795 > TEST=None BUG=385795 TBR=yzshen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286239

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+174 lines, -82 lines)			Patch
	M	mojo/system/raw_channel.cc	View		20 chunks	+34 lines, -34 lines	0 comments	Download
	M	mojo/system/raw_channel_win.cc	View		19 chunks	+140 lines, -48 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

6 years, 4 months ago (2014-07-29 17:30:11 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r286239 (presubmit successful).

Expand Messages | Collapse Messages