chrome/browser/ui/webui/inspect_ui.cc - Issue 449043002: [DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManage…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/inspect_ui.cc

Issue 449043002: [DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManage… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixed DetachAllClients Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_popup.cc ('k') | chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/inspect_ui.cc

diff --git a/chrome/browser/ui/webui/inspect_ui.cc b/chrome/browser/ui/webui/inspect_ui.cc

index dc203b6b345de2ef5accf6a07cfbc8cd89f7c0ef..6624e41904bab8960f69b9e70ab29893245a9389 100644

--- a/chrome/browser/ui/webui/inspect_ui.cc

+++ b/chrome/browser/ui/webui/inspect_ui.cc

@@ -16,7 +16,6 @@

#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

#include "content/public/browser/devtools_agent_host.h"

-#include "content/public/browser/devtools_manager.h"

#include "content/public/browser/notification_service.h"

#include "content/public/browser/notification_source.h"

#include "content/public/browser/notification_types.h"

@@ -292,10 +291,7 @@ void InspectUI::InspectBrowserWithCustomFrontend(

// Install devtools bindings.

DevToolsUIBindings* bindings = new DevToolsUIBindings(front_end,

frontend_url);

- // Engage remote debugging between front-end and agent host.

- content::DevToolsManager::GetInstance()->RegisterDevToolsClientHostFor(

- agent_host, bindings);

+ bindings->AttachTo(agent_host.get());

}

void InspectUI::InspectDevices(Browser* browser) {