Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Side by Side Diff: chrome/browser/ui/webui/inspect_ui.cc

Issue 449043002: [DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManage… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixed DetachAllClients Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/inspect_ui.h" 5 #include "chrome/browser/ui/webui/inspect_ui.h"
6 6
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "base/stl_util.h" 8 #include "base/stl_util.h"
9 #include "chrome/browser/devtools/devtools_target_impl.h" 9 #include "chrome/browser/devtools/devtools_target_impl.h"
10 #include "chrome/browser/devtools/devtools_targets_ui.h" 10 #include "chrome/browser/devtools/devtools_targets_ui.h"
11 #include "chrome/browser/devtools/devtools_ui_bindings.h" 11 #include "chrome/browser/devtools/devtools_ui_bindings.h"
12 #include "chrome/browser/profiles/profile.h" 12 #include "chrome/browser/profiles/profile.h"
13 #include "chrome/browser/ui/browser_navigator.h" 13 #include "chrome/browser/ui/browser_navigator.h"
14 #include "chrome/browser/ui/singleton_tabs.h" 14 #include "chrome/browser/ui/singleton_tabs.h"
15 #include "chrome/browser/ui/webui/theme_source.h" 15 #include "chrome/browser/ui/webui/theme_source.h"
16 #include "chrome/common/pref_names.h" 16 #include "chrome/common/pref_names.h"
17 #include "chrome/common/url_constants.h" 17 #include "chrome/common/url_constants.h"
18 #include "content/public/browser/devtools_agent_host.h" 18 #include "content/public/browser/devtools_agent_host.h"
19 #include "content/public/browser/devtools_manager.h"
20 #include "content/public/browser/notification_service.h" 19 #include "content/public/browser/notification_service.h"
21 #include "content/public/browser/notification_source.h" 20 #include "content/public/browser/notification_source.h"
22 #include "content/public/browser/notification_types.h" 21 #include "content/public/browser/notification_types.h"
23 #include "content/public/browser/user_metrics.h" 22 #include "content/public/browser/user_metrics.h"
24 #include "content/public/browser/web_contents.h" 23 #include "content/public/browser/web_contents.h"
25 #include "content/public/browser/web_contents_delegate.h" 24 #include "content/public/browser/web_contents_delegate.h"
26 #include "content/public/browser/web_ui.h" 25 #include "content/public/browser/web_ui.h"
27 #include "content/public/browser/web_ui_data_source.h" 26 #include "content/public/browser/web_ui_data_source.h"
28 #include "content/public/browser/web_ui_message_handler.h" 27 #include "content/public/browser/web_ui_message_handler.h"
29 #include "grit/browser_resources.h" 28 #include "grit/browser_resources.h"
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 inspect_ui, 284 inspect_ui,
286 content::OpenURLParams(GURL(url::kAboutBlankURL), 285 content::OpenURLParams(GURL(url::kAboutBlankURL),
287 content::Referrer(), 286 content::Referrer(),
288 NEW_FOREGROUND_TAB, 287 NEW_FOREGROUND_TAB,
289 content::PAGE_TRANSITION_AUTO_TOPLEVEL, 288 content::PAGE_TRANSITION_AUTO_TOPLEVEL,
290 false)); 289 false));
291 290
292 // Install devtools bindings. 291 // Install devtools bindings.
293 DevToolsUIBindings* bindings = new DevToolsUIBindings(front_end, 292 DevToolsUIBindings* bindings = new DevToolsUIBindings(front_end,
294 frontend_url); 293 frontend_url);
295 294 bindings->AttachTo(agent_host.get());
296 // Engage remote debugging between front-end and agent host.
297 content::DevToolsManager::GetInstance()->RegisterDevToolsClientHostFor(
298 agent_host, bindings);
299 } 295 }
300 296
301 void InspectUI::InspectDevices(Browser* browser) { 297 void InspectUI::InspectDevices(Browser* browser) {
302 content::RecordAction(base::UserMetricsAction("InspectDevices")); 298 content::RecordAction(base::UserMetricsAction("InspectDevices"));
303 chrome::NavigateParams params(chrome::GetSingletonTabNavigateParams( 299 chrome::NavigateParams params(chrome::GetSingletonTabNavigateParams(
304 browser, GURL(chrome::kChromeUIInspectURL))); 300 browser, GURL(chrome::kChromeUIInspectURL)));
305 params.path_behavior = chrome::NavigateParams::IGNORE_AND_NAVIGATE; 301 params.path_behavior = chrome::NavigateParams::IGNORE_AND_NAVIGATE;
306 ShowSingletonTabOverwritingNTP(browser, params); 302 ShowSingletonTabOverwritingNTP(browser, params);
307 } 303 }
308 304
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
482 targets); 478 targets);
483 } 479 }
484 480
485 void InspectUI::PopulatePortStatus(const base::Value& status) { 481 void InspectUI::PopulatePortStatus(const base::Value& status) {
486 web_ui()->CallJavascriptFunction("populatePortStatus", status); 482 web_ui()->CallJavascriptFunction("populatePortStatus", status);
487 } 483 }
488 484
489 void InspectUI::ShowIncognitoWarning() { 485 void InspectUI::ShowIncognitoWarning() {
490 web_ui()->CallJavascriptFunction("showIncognitoWarning"); 486 web_ui()->CallJavascriptFunction("showIncognitoWarning");
491 } 487 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698