Issue 448993003: Process Statistics header, add max RSS to render_pdfs

Issue 448993003: Process Statistics header, add max RSS to render_pdfs (Closed)

Created:
6 years, 4 months ago by hal.canary

Modified:
6 years, 4 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Process Statistics header, add max RSS to render_pdfs Committed: https://skia.googlesource.com/skia/+/6274baae7fe82ce6481da367687aa6168356e1e1 Committed: https://skia.googlesource.com/skia/+/0d154eeaebc640b7bd83e0b212fac22587610a4b

Patch Set 2 : comments from mtklein #

Patch Set 3 : compiles on macos and ios #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -42 lines)			Patch
M	dm/DMReporter.cpp	View	1	2 chunks	+4 lines, -17 lines	0 comments	Download
M	gyp/apptype_console.gypi	View	1 2	2 chunks	+24 lines, -24 lines	0 comments	Download
M	gyp/dm.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/tools.gyp	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download
A	tools/ProcStats.h	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download
A	tools/ProcStats.cpp	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
M	tools/render_pdfs_main.cpp	View	1	3 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

mtklein

lgtm https://codereview.chromium.org/448993003/diff/1/gyp/tools.gyp File gyp/tools.gyp (right): https://codereview.chromium.org/448993003/diff/1/gyp/tools.gyp#newcode533 gyp/tools.gyp:533: 'tools.gyp:sk_tool_proc_stats', funky indent? https://codereview.chromium.org/448993003/diff/1/tools/ProcStats.h File tools/ProcStats.h (right): https://codereview.chromium.org/448993003/diff/1/tools/ProcStats.h#newcode21 ...

6 years, 4 months ago (2014-08-07 19:59:51 UTC) #2

hal.canary

https://codereview.chromium.org/448993003/diff/1/gyp/tools.gyp File gyp/tools.gyp (right): https://codereview.chromium.org/448993003/diff/1/gyp/tools.gyp#newcode533 gyp/tools.gyp:533: 'tools.gyp:sk_tool_proc_stats', On 2014/08/07 19:59:51, mtklein wrote: > funky indent? ...

6 years, 4 months ago (2014-08-07 20:04:30 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/448993003/20001

6 years, 4 months ago (2014-08-07 20:05:24 UTC) #5

commit-bot: I haz the power

Change committed as 6274baae7fe82ce6481da367687aa6168356e1e1

6 years, 4 months ago (2014-08-07 20:14:00 UTC) #6

bungeman-skia

A revert of this CL has been created in https://codereview.chromium.org/448243003/ by bungeman@google.com. The reason for ...

6 years, 4 months ago (2014-08-07 20:25:58 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/448993003/100001

6 years, 4 months ago (2014-08-11 18:26:35 UTC) #9

commit-bot: I haz the power

6 years, 4 months ago (2014-08-11 18:33:56 UTC) #10

Message was sent while issue was closed.

Change committed as 0d154eeaebc640b7bd83e0b212fac22587610a4b

Expand Messages | Collapse Messages