sdk/lib/_internal/compiler/implementation/resolution/registry.dart - Issue 448943004: Refactor and simplify the dart2dart renamer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/registry.dart

Issue 448943004: Refactor and simplify the dart2dart renamer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rely (almost) only on Entity from renamer. Improve handling of privates and constructors. Avoid sor… Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/resolution/registry.dart

diff --git a/sdk/lib/_internal/compiler/implementation/resolution/registry.dart b/sdk/lib/_internal/compiler/implementation/resolution/registry.dart

index 59d99201a45a1cc4793b20173d7454c90929afe0..346c9b16e49b48c1f484fcac5d964e1ed1b504ba 100644

--- a/sdk/lib/_internal/compiler/implementation/resolution/registry.dart

+++ b/sdk/lib/_internal/compiler/implementation/resolution/registry.dart

@@ -31,6 +31,9 @@ class ResolutionRegistry extends Registry {

/// Register [node] as the declaration of [element].

void defineFunction(FunctionExpression node, FunctionElement element) {

+ if (node.name != null) {

Johnni Winther 2014/08/15 07:49:20 Add TODO to remove when not needed by the dart2dar

sigurdm 2014/08/15 13:06:27 Done.

+ mapping[node.name] = element;

+ }

mapping[node] = element;

}