sdk/lib/_internal/compiler/implementation/resolution/members.dart - Issue 448943004: Refactor and simplify the dart2dart renamer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 448943004: Refactor and simplify the dart2dart renamer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rely (almost) only on Entity from renamer. Improve handling of privates and constructors. Avoid sor… Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart

diff --git a/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/sdk/lib/_internal/compiler/implementation/resolution/members.dart

index 56941d810c7fb1fecb78c77bfd2fa4cf47e96884..7f386ab3f03d96fd6e398daf8c61b5f6b7fab0db 100644

--- a/sdk/lib/_internal/compiler/implementation/resolution/members.dart

+++ b/sdk/lib/_internal/compiler/implementation/resolution/members.dart

@@ -746,6 +746,9 @@ class ResolverTask extends CompilerTask {

}

ResolverVisitor visitor = visitorFor(element);

ResolutionRegistry registry = visitor.registry;

+ // TODO(johnnywinther): Maybe remove this when placeholderCollector migrates

Johnni Winther 2014/08/15 07:49:19 johnnywinther -> johnniwinther

sigurdm 2014/08/15 13:06:27 Done.

+ // to the backend ast.

+ registry.defineElement(tree.definitions.nodes.head, element);

// TODO(johnniwinther): Share the resolved type between all variables

// declared in the same declaration.

if (tree.type != null) {