PRESUBMIT.py - Issue 448903002: Exempts chromecast/ directory from spam-logging presubmit check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 448903002: Exempts chromecast/ directory from spam-logging presubmit check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 72aa2484806a446c78d142089b436148c76ae705..1d5fc9ad8dd180fc9b9a379dbe68166830f99df7 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -916,6 +916,7 @@ def _CheckSpamLogging(input_api, output_api):

(r"^base[\\\/]logging\.h$",

r"^base[\\\/]logging\.cc$",

r"^cloud_print[\\\/]",

+ r"^chromecast[\\\/]",

M-A Ruel 2014/08/07 01:05:17 Could you move line 918 at line 925 while at it? I

gunsch 2014/08/07 01:08:09 Done.

r"^chrome_elf[\\\/]dll_hash[\\\/]dll_hash_main\.cc$",

r"^chrome[\\\/]app[\\\/]chrome_main_delegate\.cc$",

r"^chrome[\\\/]browser[\\\/]chrome_browser_main\.cc$",

« no previous file with comments | « no previous file | no next file » | no next file with comments »