Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 898 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 909 | 909 |
| 910 | 910 |
| 911 def _CheckSpamLogging(input_api, output_api): | 911 def _CheckSpamLogging(input_api, output_api): |
| 912 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS | 912 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS |
| 913 black_list = (_EXCLUDED_PATHS + | 913 black_list = (_EXCLUDED_PATHS + |
| 914 _TEST_CODE_EXCLUDED_PATHS + | 914 _TEST_CODE_EXCLUDED_PATHS + |
| 915 input_api.DEFAULT_BLACK_LIST + | 915 input_api.DEFAULT_BLACK_LIST + |
| 916 (r"^base[\\\/]logging\.h$", | 916 (r"^base[\\\/]logging\.h$", |
| 917 r"^base[\\\/]logging\.cc$", | 917 r"^base[\\\/]logging\.cc$", |
| 918 r"^cloud_print[\\\/]", | 918 r"^cloud_print[\\\/]", |
| 919 r"^chromecast[\\\/]", | |
|
M-A Ruel
2014/08/07 01:05:17
Could you move line 918 at line 925 while at it? I
gunsch
2014/08/07 01:08:09
Done.
| |
| 919 r"^chrome_elf[\\\/]dll_hash[\\\/]dll_hash_main\.cc$", | 920 r"^chrome_elf[\\\/]dll_hash[\\\/]dll_hash_main\.cc$", |
| 920 r"^chrome[\\\/]app[\\\/]chrome_main_delegate\.cc$", | 921 r"^chrome[\\\/]app[\\\/]chrome_main_delegate\.cc$", |
| 921 r"^chrome[\\\/]browser[\\\/]chrome_browser_main\.cc$", | 922 r"^chrome[\\\/]browser[\\\/]chrome_browser_main\.cc$", |
| 922 r"^chrome[\\\/]browser[\\\/]ui[\\\/]startup[\\\/]" | 923 r"^chrome[\\\/]browser[\\\/]ui[\\\/]startup[\\\/]" |
| 923 r"startup_browser_creator\.cc$", | 924 r"startup_browser_creator\.cc$", |
| 924 r"^chrome[\\\/]installer[\\\/]setup[\\\/].*", | 925 r"^chrome[\\\/]installer[\\\/]setup[\\\/].*", |
| 925 r"^extensions[\\\/]renderer[\\\/]logging_native_handler\.cc$", | 926 r"^extensions[\\\/]renderer[\\\/]logging_native_handler\.cc$", |
| 926 r"^content[\\\/]common[\\\/]gpu[\\\/]client[\\\/]" | 927 r"^content[\\\/]common[\\\/]gpu[\\\/]client[\\\/]" |
| 927 r"gl_helper_benchmark\.cc$", | 928 r"gl_helper_benchmark\.cc$", |
| 928 r"^native_client_sdk[\\\/]", | 929 r"^native_client_sdk[\\\/]", |
| (...skipping 692 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1621 builders.extend(['cros_x86']) | 1622 builders.extend(['cros_x86']) |
| 1622 | 1623 |
| 1623 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it | 1624 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it |
| 1624 # unless they're .gyp(i) files as changes to those files can break the gyp | 1625 # unless they're .gyp(i) files as changes to those files can break the gyp |
| 1625 # step on that bot. | 1626 # step on that bot. |
| 1626 if (not all(re.search('^chrome', f) for f in files) or | 1627 if (not all(re.search('^chrome', f) for f in files) or |
| 1627 any(re.search('\.gypi?$', f) for f in files)): | 1628 any(re.search('\.gypi?$', f) for f in files)): |
| 1628 builders.extend(['android_aosp']) | 1629 builders.extend(['android_aosp']) |
| 1629 | 1630 |
| 1630 return GetDefaultTryConfigs(builders) | 1631 return GetDefaultTryConfigs(builders) |
| OLD | NEW |