Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 448903002: Exempts chromecast/ directory from spam-logging presubmit check. (Closed)

Created:
6 years, 4 months ago by gunsch
Modified:
6 years, 4 months ago
Reviewers:
lcwu1, M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Exempts chromecast/ directory from spam-logging presubmit check. None of chromecast/ is part of chrome binary. R=lcwu@chromium.org,maruel@chromium.org BUG=None NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287946

Patch Set 1 #

Total comments: 2

Patch Set 2 : alphabetization #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M PRESUBMIT.py View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
gunsch
6 years, 4 months ago (2014-08-06 23:39:30 UTC) #1
lcwu1
lgtm
6 years, 4 months ago (2014-08-06 23:45:46 UTC) #2
M-A Ruel
https://codereview.chromium.org/448903002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/448903002/diff/1/PRESUBMIT.py#newcode919 PRESUBMIT.py:919: r"^chromecast[\\\/]", Could you move line 918 at line 925 ...
6 years, 4 months ago (2014-08-07 01:05:18 UTC) #3
gunsch
https://codereview.chromium.org/448903002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/448903002/diff/1/PRESUBMIT.py#newcode919 PRESUBMIT.py:919: r"^chromecast[\\\/]", On 2014/08/07 01:05:17, M-A Ruel wrote: > Could ...
6 years, 4 months ago (2014-08-07 01:08:09 UTC) #4
M-A Ruel
Thanks! lgtm
6 years, 4 months ago (2014-08-07 01:12:10 UTC) #5
M-A Ruel
On 2014/08/07 01:12:10, M-A Ruel wrote: > Thanks! > > lgtm Fixed CL description.
6 years, 4 months ago (2014-08-07 01:12:41 UTC) #6
M-A Ruel
The CQ bit was checked by maruel@chromium.org
6 years, 4 months ago (2014-08-07 01:12:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/448903002/20001
6 years, 4 months ago (2014-08-07 01:15:29 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 02:59:39 UTC) #9
Message was sent while issue was closed.
Change committed as 287946

Powered by Google App Engine
This is Rietveld 408576698