chrome/test/chromedriver/chrome_launcher.cc - Issue 448853002: Move StringToLowerASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome_launcher.cc

Issue 448853002: Move StringToLowerASCII to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome_launcher.cc

diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc

index 480332c5eca6744582de32a63fe93d6e6307f63a..d54377aab7d9789b24baf6b729bdbcd76aa938fd 100644

--- a/chrome/test/chromedriver/chrome_launcher.cc

+++ b/chrome/test/chromedriver/chrome_launcher.cc

@@ -538,7 +538,8 @@ void ConvertHexadecimalToIDAlphabet(std::string* id) {

std::string GenerateExtensionId(const std::string& input) {

uint8 hash[16];

crypto::SHA256HashString(input, hash, sizeof(hash));

- std::string output = StringToLowerASCII(base::HexEncode(hash, sizeof(hash)));

+ std::string output =

+ base::StringToLowerASCII(base::HexEncode(hash, sizeof(hash)));

ConvertHexadecimalToIDAlphabet(&output);

return output;

}